Skip to content

chore: migrate biome configuration to the recommended preset - #173

Open
zimeg wants to merge 3 commits into
mainfrom
biome-migrate
Open

zimeg wants to merge 3 commits into
mainfrom
biome-migrate

Conversation

@zimeg

@zimeg zimeg commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

Biome now warns that linter.rules.recommended is deprecated and will be removed in the next major version, in favor of linter.rules.preset. This runs biome migrate --write on the sample's biome.json:

     "rules": {
-      "recommended": true
+      "preset": "recommended"
     }

Testing

  • The lint and lint:fix scripts now run on the whole project (npx @biomejs/biome check . and npx @biomejs/biome check --write .), matching the other samples.
  • Applied Biome's formatting to files the narrower lint paths had skipped: manifest.json, tests/actions/sample-action.spec.js, tests/commands/sample-command.spec.js, tests/views/sample-view.spec.js. These are whitespace-only changes.
  • npx @biomejs/biome check . now passes with no errors and no deprecation notice.

🤖 Generated with Claude Code

Biome deprecated `linter.rules.recommended` in favor of
`linter.rules.preset`. This applies `biome migrate --write` to the
sample's configuration so `biome check` runs without the warning.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner October 8, 2026 00:03
@zimeg zimeg self-assigned this Oct 8, 2026
zimeg and others added 2 commits October 7, 2026 17:12
The lint script checked only some paths, so files like manifest.json
were never formatted. Lint the project root and apply biome's
formatting to the files it had skipped.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Match the lint script so lint:fix writes fixes for every file that
lint checks.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant